Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(ui5-tabcontainer): support responsive paddings #2775

Merged
merged 21 commits into from
Feb 23, 2021
Merged

feat(ui5-tabcontainer): support responsive paddings #2775

merged 21 commits into from
Feb 23, 2021

Conversation

TeodorTaushanov
Copy link
Member

@TeodorTaushanov TeodorTaushanov commented Feb 3, 2021 •
edited
Loading

Fixes: #2539

@CLAassistant
Copy link

CLAassistant commented Feb 3, 2021 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

ilhan007
ilhan007 previously requested changes Feb 3, 2021
View reviewed changes
Copy link
Member

@ilhan007 ilhan007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Teo, is this the issue that the change is for: #2539

If yes could you assign yourself and reference it with FIXES in the commit message description.

Can you check the TabInStrip.css it shows too many changes due to the spaces/tabs or something like that.

@georgimkv georgimkv requested a review from a team February 3, 2021 16:13
@TeodorTaushanov TeodorTaushanov requested review from a team and ilhan007 February 5, 2021 13:37
georgimkv
georgimkv reviewed Feb 9, 2021
View reviewed changes
packages/base/src/Device.js Outdated Show resolved Hide resolved
packages/base/src/Device.js Outdated Show resolved Hide resolved
packages/main/src/TabContainer.hbs Show resolved Hide resolved
georgimkv
georgimkv previously approved these changes Feb 9, 2021
View reviewed changes
@ilhan007 ilhan007 mentioned this pull request Feb 9, 2021
Closed
vladitasev
vladitasev previously requested changes Feb 16, 2021
View reviewed changes
packages/base/src/Device.js Outdated Show resolved Hide resolved
packages/base/src/Device.js Outdated Show resolved Hide resolved
packages/base/src/Device.js Outdated Show resolved Hide resolved
@TeodorTaushanov TeodorTaushanov requested a review from a team February 17, 2021 13:35
@TeodorTaushanov
feat(ui5-tabcontainer): Responsive paddings are now supported
c9d4354 
fixes SAP#2539
@TeodorTaushanov
feat(ui5-tabcontainer): Responsive paddings are now supported
6c16f23 
fixes SAP#2539
@TeodorTaushanov
feat(ui5-tabcontainer): Responsive paddings are now supported
0d82716 
fixes SAP#2539
@TeodorTaushanov
feat(ui5-tabcontainer): Responsive paddings are now supported
ae6fbaa 
fixes SAP#2539
@TeodorTaushanov
feat(ui5-tabcontainer): Responsive paddings are now supported
bd13c8c 
fixes SAP#2539
@TeodorTaushanov
feat(ui5-tabcontainer): Responsive paddings are now supported
e797003 
fixes SAP#2539
@TeodorTaushanov
feat(ui5-tabcontainer): Responsive paddings are now supported
f63b4bc 
fixes SAP#2539
@TeodorTaushanov
feat(ui5-tabcontainer): Responsive paddings are now supported
80b8c4e 
Fixes: SAP#2539
@TeodorTaushanov
feat(ui5-tabcontainer): Responsive paddings are now supported
ef9e4d3 
Fixes: SAP#2539
@TeodorTaushanov
feat(ui5-tabcontainer): Responsive paddings are now supported
42e34da 
Fixes: SAP#2539
@TeodorTaushanov
feat(ui5-tabcontainer): Responsive paddings are now supported
578cef4 
Fixes: SAP#2539
@TeodorTaushanov
feat(ui5-tabcontainer): Responsive paddings are now supported
f24b408 
Fixes: SAP#2539
georgimkv
georgimkv previously approved these changes Feb 17, 2021
View reviewed changes
ilhan007
ilhan007 previously approved these changes Feb 23, 2021
View reviewed changes
Copy link
Member

@ilhan007 ilhan007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We agreed offline to fix few minor things, the rest of code is fine, also tested that the responsive paddings are working fine - I approve

@ilhan007 ilhan007 changed the title feat(ui5-tabcontainer): Responsive paddings are now supported feat(ui5-tabcontainer): support responsive paddings Feb 23, 2021
@ilhan007 ilhan007 merged commit 19392ff into SAP:master Feb 23, 2021
@TeodorTaushanov TeodorTaushanov deleted the TabContainerButtons branch February 23, 2021 11:24
ilhan007 pushed a commit that referenced this pull request Jun 23, 2021
@TeodorTaushanov @ilhan007
feat(ui5-tabcontainer): support responsive paddings (#2775)
398e7d6 
Fixes: #2539
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ilhan007 ilhan007 ilhan007 approved these changes

@vladitasev vladitasev Awaiting requested review from vladitasev

@georgimkv georgimkv Awaiting requested review from georgimkv

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

TabContainer: implement responsive paddings
5 participants
@TeodorTaushanov @CLAassistant @ilhan007 @vladitasev @georgimkv