fix(ui5-popup): hide block layer if popup is closed #2799
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The block layer is created when #getStaticAreaItemDomRef is called, but the attribute "hidden" is not set at that time. Now it's set on onEnterDOM hook, unless the popup is already opened. Fixes: #2696
ilhan007
approved these changes
Feb 9, 2021
ilhan007
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The block layer is created when #getStaticAreaItemDomRef is called, but the attribute "hidden" is not set at that time. Now it's set on onEnterDOM hook, unless the popup is already opened.
Fixes: #2696
Thank you for your contribution! 👏
To get it merged faster, kindly review the checklist below:
Pull Request Checklist