Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ui5-multi-combobox): correct focus handling when picker is opened #2868

Merged
merged 2 commits into from
Feb 26, 2021
Merged

fix(ui5-multi-combobox): correct focus handling when picker is opened #2868

merged 2 commits into from
Feb 26, 2021

Conversation

ivoplashkov
Copy link
Member

  • The focus of the MultiComboBox used to be lost when opened via icon, because we were moving the focus to the input after the ResponsivePopover has handled it's restoreFocus logic and the target of the focus restoration was the icon instead of the Input. This is not the case anymore, since we are forcing the focus inside the input, before we are toggling the ResponsivePopover.

FIXES: #2535
FIXES: #2473

@fifoosid fifoosid changed the title fix(ui5-multi-combobox): Correct focus handling when picker is opened… fix(ui5-multi-combobox): correct focus handling when picker is opened Feb 26, 2021
@fifoosid fifoosid merged commit 76ef62c into master Feb 26, 2021
@fifoosid fifoosid deleted the mcb-focus-issue branch February 26, 2021 09:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fifoosid fifoosid fifoosid approved these changes

@ilhan007 ilhan007 Awaiting requested review from ilhan007

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

MultiComboBox focusout issue Investigate and fix consistently failing MultiComboBox test
2 participants
@ivoplashkov @fifoosid