New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: ensure locales don't use reserved JS names #2885

Merged

pskelin merged 1 commit into master from fix-import-identifiers

Mar 2, 2021

Contributor

pskelin commented Mar 1, 2021

Locale id in matches a JS keyword and cannot be used in import identifier.

This change prefixes all import variables like _in so they never overlap language keywords.


          fix: ensure locales don't use reserved JS names

e0e33f8

pskelin mentioned this pull request

chore: remove in language temporarily #2879

Closed

vladitasev approved these changes

View reviewed changes

pskelin merged commit 05fc06e into master

pskelin deleted the fix-import-identifiers branch

March 2, 2021 06:59

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment