Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ui5-upload-collection): add tooltip to Edit button #2886

Merged
merged 2 commits into from
Mar 1, 2021
Merged

fix(ui5-upload-collection): add tooltip to Edit button #2886

merged 2 commits into from
Mar 1, 2021

Conversation

georgimkv
Copy link
Contributor

No description provided.

@georgimkv georgimkv requested a review from a team March 1, 2021 08:49
fifoosid
fifoosid suggested changes Mar 1, 2021
View reviewed changes
Copy link
Contributor

@fifoosid fifoosid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From technical point of view looks good to me, just some docs.

packages/fiori/src/UploadCollection.js Outdated Show resolved Hide resolved
packages/fiori/src/UploadCollection.js Outdated Show resolved Hide resolved
@georgimkv georgimkv requested a review from fifoosid March 1, 2021 11:21
@fifoosid fifoosid merged commit 35de38c into SAP:master Mar 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fifoosid fifoosid fifoosid approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@georgimkv @fifoosid