fix(ui5-popover): calculate offset for all sides of the page #2916
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fifoosid
previously approved these changes
Mar 8, 2021
TeodorTaushanov
previously approved these changes
Mar 19, 2021
The popover has a 10px offset from the edges of the screen, so that its size would not reach the border of the page. Left and Top positons are now clamped to adjust for that offset on all sides. Fixes: #2697
|
Rebased to resolve merge confict. |
fifoosid
approved these changes
Mar 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The popover has a 10px offset from the edges of the screen,
so that its size would not reach the border of the page.
Left and Top positons are now clamped to adjust for that offset on all sides.
Fixes: #2697