Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ui5-color-palette): remove additional dots in more-colors #2958

Merged
merged 2 commits into from
Mar 17, 2021
Merged

fix(ui5-color-palette): remove additional dots in more-colors #2958

merged 2 commits into from
Mar 17, 2021

Conversation

ilhan007
Copy link
Member

  • More colors text used to have 6 dots (3 from the template and 3 from the translated text)
  • sample updated to show real-case scenario of ColorPalette with "more-colors" set.

@ilhan007 ilhan007 requested a review from fifoosid March 17, 2021 14:53
fifoosid
fifoosid previously approved these changes Mar 17, 2021
View reviewed changes
fifoosid
fifoosid suggested changes Mar 17, 2021
View reviewed changes
Copy link
Contributor

@fifoosid fifoosid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All events should be with the ui5- prefix

@ilhan007 ilhan007 merged commit 8ef07fe into master Mar 17, 2021
@ilhan007 ilhan007 deleted the sample branch March 17, 2021 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vladitasev vladitasev vladitasev approved these changes

@fifoosid fifoosid fifoosid approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ilhan007 @vladitasev @fifoosid