fix(ui5-rangeslider): fix handles opacity for IE11 #2983
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ndeshev
force-pushed
the
rs-handle-opacity-ie
branch
from
78d1955
to
5615f7a
Compare
vladitasev
previously approved these changes
Mar 22, 2021
ilhan007
reviewed
Mar 22, 2021
niyap
reviewed
Mar 23, 2021
| @@ -9,14 +9,14 @@ | |||
| --_ui5_slider_handle_width: 1.625rem; | |||
| --_ui5_slider_handle_border: solid 0.125rem var(--sapField_BorderColor); | |||
| --_ui5_slider_handle_background: var(--sapButton_Background); | |||
| --_ui5_range_slider_handle_background: rgba(var(--sapButton_Background), 0.25); | |||
| --_ui5_range_slider_handle_background: rgba(255, 255, 255, 0.25); | |||
There was a problem hiding this comment.
On hover over the progress bar in Internet Explorer, the handles are still not transparent.
There was a problem hiding this comment.
My mistake, it works as expected :)
niyap
approved these changes
Mar 25, 2021
ilhan007
pushed a commit
that referenced
this pull request
Mar 31, 2021
Range Slider's handles' background is now fixed to be consistent across all browsers, as previously their opacity was not correct in IE11.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Range Slider's handles' background is now fixed to be consistent across all browsers, as previously their opacity was not correct in IE11.