Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ui5-dialog): Fixed RTL mode #3070

Merged
merged 4 commits into from
Apr 1, 2021
Merged

fix(ui5-dialog): Fixed RTL mode #3070

merged 4 commits into from
Apr 1, 2021

Conversation

TeodorTaushanov
Copy link
Member

Fixes: #3013

@TeodorTaushanov TeodorTaushanov requested review from ilhan007 and a team March 31, 2021 14:14
ilhan007
ilhan007 previously approved these changes Mar 31, 2021
View reviewed changes
@TeodorTaushanov TeodorTaushanov requested a review from a team April 1, 2021 06:41
fifoosid
fifoosid previously requested changes Apr 1, 2021
View reviewed changes
Copy link
Contributor

@fifoosid fifoosid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change is great, just check the failing lint

@ilhan007 ilhan007 merged commit 0aac048 into master Apr 1, 2021
@ilhan007 ilhan007 deleted the DialogRTL branch April 1, 2021 09:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ilhan007 ilhan007 ilhan007 approved these changes

@fifoosid fifoosid Awaiting requested review from fifoosid

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Dialog: RTL is not working
3 participants
@TeodorTaushanov @ilhan007 @fifoosid