feat: enable radio button form support #357
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ilhan007
reviewed
Apr 23, 2019
packages/main/src/RadioButton.js
Outdated
| @@ -167,6 +190,15 @@ class RadioButton extends UI5Element { | |||
| onBeforeRendering() { | |||
| this.syncLabel(); | |||
| this.syncGroup(); | |||
|
|
|||
| if (RadioButton.FormSupport) { | |||
There was a problem hiding this comment.
Seems great, do you mind extracting the form support code block in a separate method -enableFormSupport or something similar, just to keep the onBeforeRendering lean.
onBeforeRendering() {
this.syncLabel();
this.syncGroup();
this.enableFormSupport();
}
ilhan007
previously approved these changes
Apr 23, 2019
ilhan007
approved these changes
Apr 23, 2019
MapTo0
approved these changes
Apr 23, 2019
MapTo0
reviewed
Apr 23, 2019
| } | ||
|
|
||
| syncLabel() { | ||
| this._label = Object.assign({}, this._label); |
There was a problem hiding this comment.
this can be shorten a bit, but I not important at all
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for your contribution! 馃憦
To get it merged faster, kindly review the checklist below:
Pull Request Checklist