feat(ui5-multi-combobox): initial implementation #379
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MapTo0
force-pushed
the
multi-combobox-implementation
branch
from
e950be6
to
df50039
Compare
ilhan007
reviewed
May 21, 2019
ilhan007
reviewed
May 21, 2019
ilhan007
reviewed
May 21, 2019
ilhan007
reviewed
May 21, 2019
ilhan007
reviewed
May 21, 2019
ilhan007
reviewed
May 21, 2019
ilhan007
reviewed
May 21, 2019
ilhan007
reviewed
May 21, 2019
| input.value = this._inputLastValue; | ||
| input.valueState = "Error"; | ||
|
|
||
| setTimeout(() => { |
There was a problem hiding this comment.
This seems like a workaround, maybe there is something that lacks in the framework.
I think we should at least talk about it briefly, if we can do something else.
ilhan007
approved these changes
May 21, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes: #314