Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add data-ui5-compact-size attribute to root when compact is set #382

Merged
merged 1 commit into from
May 13, 2019
Merged

feat: add data-ui5-compact-size attribute to root when compact is set #382

merged 1 commit into from
May 13, 2019

Conversation

MapTo0
Copy link
Member

@MapTo0 MapTo0 commented May 13, 2019

  • in order to have easier styling of the sizes of the components all the css should be applied to the root of the element (such as width, height, etc).
  • when having a compact size setting applied, all components should change their sizes, in order to track this change in the css we add a private data attribute to the root of each element

@MapTo0
feat: add data-ui5-compact-size attribute to root when compact is set
925f7cc 
- in order to have easier styling of the sizes of the components all the css
should be applied to the root of the element (such as width, height, etc).
- when having a compact size setting applied, all components should change their sizes, in
order to track this change in the css we add a private data attribute to the root of each element
@MapTo0 MapTo0 merged commit cbf00a8 into master May 13, 2019
@MapTo0 MapTo0 deleted the root-compact-setting branch May 13, 2019 10:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vladitasev vladitasev vladitasev approved these changes

@ilhan007 ilhan007 Awaiting requested review from ilhan007

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@MapTo0 @vladitasev