Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ui5-slider): show tooltips when component has focus #3899

Merged
merged 2 commits into from Sep 14, 2021
Merged

fix(ui5-slider): show tooltips when component has focus #3899

merged 2 commits into from Sep 14, 2021

Conversation

xpr0gamers
Copy link
Contributor

fix: #3779

@fifoosid fifoosid requested a review from a team September 13, 2021 08:58
fifoosid
fifoosid suggested changes Sep 13, 2021
View reviewed changes
Copy link
Contributor

@fifoosid fifoosid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Eslint is failing:

image

@fifoosid fifoosid merged commit 952445d into SAP:master Sep 14, 2021
@xpr0gamers xpr0gamers deleted the slider-tooltip branch September 14, 2021 09:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fifoosid fifoosid fifoosid approved these changes

@niyap niyap niyap approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Android] RangeSlider handle tooltips disappear
3 participants
@xpr0gamers @fifoosid @niyap