fix: fix API build for composite components #391
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some of the components do not have separate sample page, but are appended to others sample page. The API of those components is part (in most cases) of parent components API, that use them as composite components. Issue: the API of the composite/child components misses base properties. Root cause: the API generataion of the parent component is done before the API generation of the composite/child compoenents. Solution: calculate the API of those composite components before their addiotion to parent`s component API. FIXES: #390
pskelin
approved these changes
May 15, 2019
pskelin
approved these changes
May 15, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FIXES: #390
Before (StandardListItem "selected" and "type" properties are missing)
After (StandardListItem "selected" and "type" properties are in place)