Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ui5-card): add "headerInteractive" property #439

Merged
merged 6 commits into from
Jun 17, 2019

Conversation

ilhan007
Copy link
Member

@ilhan007 ilhan007 commented May 23, 2019

Fixes: #429
Fixes: #430

@ilhan007 ilhan007 changed the title Feat card header active feat(ui5-card): add headerInteractive property May 23, 2019
@ilhan007 ilhan007 changed the title feat(ui5-card): add headerInteractive property feat(ui5-card): add "headerInteractive" property May 23, 2019
Copy link
Contributor

@fifoosid fifoosid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the docs it is written that both space and enter are firing the event

if (!this.headerInteractive) {
return;
}

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the docs it is written that both space and enter are firing the event

@MapTo0
Copy link
Member

MapTo0 commented May 23, 2019

active-header sounds better to me :D

interactive-header
clickable-header

header-interactive looks strange tbh

fifoosid
fifoosid previously approved these changes May 23, 2019
@ilhan007 ilhan007 merged commit 98f7075 into master Jun 17, 2019
@ilhan007 ilhan007 deleted the feat-card-header-active branch June 17, 2019 07:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants