Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(base): implement late validation #522

Merged
merged 3 commits into from
Jun 10, 2019
Merged

feat(base): implement late validation #522

merged 3 commits into from
Jun 10, 2019

Conversation

vladitasev
Copy link
Contributor

Late validation allows to delay the validation of slot content until custom elements have been defined.

Note: only enable late validation on web components that don't depend on their children being defined. This may include setting properties/attributes, but not calling methods or instance checking.

To support this change, UI5Element now upgrades all properties (including private) so that when a parent web component sets private properties to children, these will be upgraded as well eventually.

To enable the feature for a slot, use "lateValidation: true"

@vladitasev vladitasev merged commit c452d60 into master Jun 10, 2019
@vladitasev vladitasev deleted the lazy-validation branch June 10, 2019 10:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants