Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add noHeader prop to Card component #643

Closed
Lukas742 opened this issue Jul 11, 2019 · 3 comments · Fixed by #646
Closed

Add noHeader prop to Card component #643

Lukas742 opened this issue Jul 11, 2019 · 3 comments · Fixed by #646

Comments

@Lukas742
Copy link
Collaborator

Is your feature request related to a problem? Please describe.
I would like to use the Card in a similar layout like the sap.m.Tile control.

Describe the solution you'd like
Add the noHeader prop to the Card, so that I can use the content slot only.

Describe alternatives you've considered
Create own Tile component.

@ilhan007
Copy link
Member

Hello @Lukas742
Thanks for you request, we will consider it.

To help us better understand your needs, could you please answer these questions.
In case you don't need the header, do you actually need ui5-card?
Do you need it because of the ui5-card border you get?

Because,
you can just use the content html that you would set to the ui5 -card content slot,
directly in your page with the same result.

Best,
ilhan

@ilhan007
Copy link
Member

Hello @Lukas742

In addition to my previous comment, I want to inform you that we prepared a change #646,
that removes the header part of the ui5-card, if the properties heading avatar, subtitle and status (all defining parts of the header) are not used/set. In other words, if you don`t use anything related to the header, a header will not be rendered.

I think that the change might also meet your needs, without adding a dedicated property noHeader.
What do you think?

@Lukas742
Copy link
Collaborator Author

Hi @ilhan007

Thanks this is exactly what I needed. And yes you were right, I could've just used the html in the content slot, but this way it's easier to implement.

Kind regards,
Lukas

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants