New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ui5-button): fix Transparent button border in Fiori 3 & HCB #789

Merged

ilhan007 merged 2 commits into master from fix-button-transparent

Sep 25, 2019

Member

ilhan007 commented Sep 24, 2019 •

edited

Loading

Fixes: #788
Two corrections:

Border provided for Transparent button upon hover in Fiori 3:

In HCB there should be always a border even for Transparent button (hovered or not):

Note:

However, in Belize there is no border on hover for Transparent button and this is kept as it is currently:

ilhan007 added 2 commits

September 24, 2019 16:57


          fix(ui5-button): correct transparent button border in Fiori3 and HCB

7ef81f8


          fix typo

78bc786

ilhan007 requested a review from MapTo0

September 24, 2019 14:09

vladitasev approved these changes

View reviewed changes

ilhan007 merged commit bc00f1f into master

ilhan007 deleted the fix-button-transparent branch

September 25, 2019 06:31

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment