-
Notifications
You must be signed in to change notification settings - Fork 254
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(ui5-side-navigation): Add new overflow behaviour to collapsed mode #8019
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
GerganaKremenska
force-pushed
the
sideNav_overflow
branch
2 times, most recently
from
December 20, 2023 14:17
f96a586
to
eb7e4b6
Compare
GerganaKremenska
force-pushed
the
sideNav_overflow
branch
3 times, most recently
from
January 5, 2024 08:31
bdcff5e
to
c3ba136
Compare
GerganaKremenska
force-pushed
the
sideNav_overflow
branch
from
January 8, 2024 06:20
c3ba136
to
a86ddaa
Compare
Added accessibility
GerganaKremenska
force-pushed
the
sideNav_overflow
branch
2 times, most recently
from
January 9, 2024 09:06
f280a39
to
614cb11
Compare
GerganaKremenska
force-pushed
the
sideNav_overflow
branch
from
January 9, 2024 09:14
614cb11
to
e9130a7
Compare
fixed since and button is changed to <div>
overflow is now a div
GerganaKremenska
force-pushed
the
sideNav_overflow
branch
from
January 10, 2024 08:04
11f81d4
to
f47fc81
Compare
GerganaKremenska
requested review from
alexandar-mitsev,
kskondov and
dimovpetar
January 10, 2024 08:20
GerganaKremenska
force-pushed
the
sideNav_overflow
branch
from
January 10, 2024 11:59
2b76d4f
to
fb3fbfb
Compare
TeodorTaushanov
approved these changes
Jan 10, 2024
GerganaKremenska
changed the title
feat(ui5-side-navigation): overflow
feat(ui5-side-navigation): new overflow behaviour is introduced
Jan 10, 2024
GerganaKremenska
changed the title
feat(ui5-side-navigation): new overflow behaviour is introduced
feat(ui5-side-navigation): new overflow behaviour to collapsed mode is introduced
Jan 10, 2024
GerganaKremenska
changed the title
feat(ui5-side-navigation): new overflow behaviour to collapsed mode is introduced
feat(ui5-side-navigation): Add new overflow behaviour to collapsed mode
Jan 10, 2024
PetyaMarkovaBogdanova
pushed a commit
that referenced
this pull request
Jan 17, 2024
…de (#8019) * feat(ui5-side-navigation): overflow * feat(ui5-side-navigation): overflow Added accessibility * feat(ui5-side-navigation): overflow * feat(ui5-side-navigation): overflow added fixed since and button is changed to <div> * feat(ui5-side-navigation): overflow overflow is now a div * feat(ui5-side-navigation): overflow * feat(ui5-side-navigation): added tooltip to overflow icon
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When there is not enough space in the side navigation and collapsed is set. The items will show in an overflow menu.