Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ui5-side-navigation): Add new overflow behaviour to collapsed mode #8019

Merged
merged 8 commits into from
Jan 10, 2024

Conversation

GerganaKremenska
Copy link
Member

@GerganaKremenska GerganaKremenska commented Dec 18, 2023

When there is not enough space in the side navigation and collapsed is set. The items will show in an overflow menu.

@TeodorTaushanov
Copy link
Member

  • When there is no overflow items, the overflow button is still visible
  • After an item is chosen from the overflow menu, it should get the focus.
  • Icons are missing in the overflow menu.
  • Select a second level item from the overflow menu, expand the side navigation - the selected item is not correct.

@GerganaKremenska GerganaKremenska force-pushed the sideNav_overflow branch 2 times, most recently from f96a586 to eb7e4b6 Compare December 20, 2023 14:17
@GerganaKremenska GerganaKremenska force-pushed the sideNav_overflow branch 3 times, most recently from bdcff5e to c3ba136 Compare January 5, 2024 08:31
@GerganaKremenska GerganaKremenska force-pushed the sideNav_overflow branch 2 times, most recently from f280a39 to 614cb11 Compare January 9, 2024 09:06
fixed since and button is changed to <div>
@GerganaKremenska GerganaKremenska changed the title feat(ui5-side-navigation): overflow feat(ui5-side-navigation): new overflow behaviour is introduced Jan 10, 2024
@GerganaKremenska GerganaKremenska changed the title feat(ui5-side-navigation): new overflow behaviour is introduced feat(ui5-side-navigation): new overflow behaviour to collapsed mode is introduced Jan 10, 2024
@GerganaKremenska GerganaKremenska changed the title feat(ui5-side-navigation): new overflow behaviour to collapsed mode is introduced feat(ui5-side-navigation): Add new overflow behaviour to collapsed mode Jan 10, 2024
@GerganaKremenska GerganaKremenska merged commit e5f8edd into main Jan 10, 2024
8 checks passed
@GerganaKremenska GerganaKremenska deleted the sideNav_overflow branch January 10, 2024 12:34
PetyaMarkovaBogdanova pushed a commit that referenced this pull request Jan 17, 2024
…de (#8019)

* feat(ui5-side-navigation): overflow

* feat(ui5-side-navigation): overflow
Added accessibility

* feat(ui5-side-navigation): overflow

* feat(ui5-side-navigation): overflow added

fixed since and button is changed to <div>

* feat(ui5-side-navigation): overflow

overflow is now a div

* feat(ui5-side-navigation): overflow

* feat(ui5-side-navigation): added tooltip to overflow icon
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants