refactor(ui5-li*): remove background CSS Variable #802
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously it was not possible to change the ui5-li* backgorund directly,
but through CSS variables, now you can set the background directly on the tag:
ui5-li {background: pink}
BREAKING CHANGE: CSS variable --ui5-listitem-background-color is removed,
set the desired background directly on the tag.
vladitasev
approved these changes
Sep 30, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously it was not possible to change the
ui5-li*components background directly,but through CSS variables, now you can set the background directly on the tag:
BREAKING CHANGE: CSS variable
--ui5-listitem-background-coloris removed,set the desired background directly on the tag.