feat(ui5-shellbar): introducing Joule #8036
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
- fixed failing tests and added a new one
-improved styling of searchfield
- removed product switch from story samples - renamed story sample to use the word Joule instead of Co Pilot
ilhan007
reviewed
Jan 18, 2024
- now the menu button has focus while being active
- imported da and da-2 (joule) icons
|
Can you check if the underline of Search, when it is focused, can be removed , as it looks weird in different states (error) - red focus and blue underline. |
- refactored arrow down icon of the menu button - search field vertically centered - replaced newly added redundant bottom border with additional box-shadow for the search field
Check out my new commit and its message :) |
IlianaB
approved these changes
Jan 25, 2024
tsanislavgatev
pushed a commit
that referenced
this pull request
Feb 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.