Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: update tnt/icons to v3.5 #8098

Merged
merged 2 commits into from
Jan 15, 2024
Merged

feat: update tnt/icons to v3.5 #8098

merged 2 commits into from
Jan 15, 2024

Conversation

ilhan007
Copy link
Member

@ilhan007 ilhan007 commented Jan 12, 2024 •
edited
Loading

Update tnt/icons based on the latest v2 and v3 fonts available + add the following new tnt icons:

        <ui5-icon name="tnt/build-apps"></ui5-icon>
        <ui5-icon name="tnt/build-work-zone"></ui5-icon>
	<ui5-icon name="tnt/build-process-automation"></ui5-icon>
	<ui5-icon name="tnt/indicator"></ui5-icon>
	<ui5-icon name="tnt/indicator-active"></ui5-icon>
	<ui5-icon name="tnt/task-optional"></ui5-icon>
	<ui5-icon name="tnt/task-done"></ui5-icon>
	<ui5-icon name="tnt/ai-1"></ui5-icon>
	<ui5-icon name="tnt/ai-2"></ui5-icon>
	<ui5-icon name="tnt/bound-validation-rule"></ui5-icon>
	<ui5-icon name="tnt/fiori-application"></ui5-icon>
	<ui5-icon name="tnt/build-code"></ui5-icon>
Screenshot 2024-01-12 at 16 38 04

Fixes: #8092

@nnaydenow
Copy link
Contributor

nnaydenow commented Jan 13, 2024 •
edited
Loading

In icon explorer tnt/indicator and tnt/task-done are centrally align. Can we check if manual adjustments are needed for here before merging them?

UI5 webcomponents
image

OpenUI5:
image
image

@ilhan007
Copy link
Member Author

In icon explorer tnt/indicator and tnt/task-done are centrally align. Can we check if manual adjustments are needed for here before merging them?

UI5 webcomponents image

OpenUI5: image image

Point taken - icons are adjusted and properly centered.
Screenshot 2024-01-14 at 20 00 30
Screenshot 2024-01-14 at 20 00 42

@ilhan007 ilhan007 merged commit 745a9fa into main Jan 15, 2024
7 of 8 checks passed
@ilhan007 ilhan007 deleted the feat-update-tnt-icons branch January 15, 2024 08:48
@ilhan007 ilhan007 added this to the 1.22.0 milestone Jan 15, 2024
@ilhan007 ilhan007 added this to Completed in Planning - Topic Core Jan 15, 2024
PetyaMarkovaBogdanova pushed a commit that referenced this pull request Jan 17, 2024
@ilhan007
feat: update tnt/icons to v3.5 (#8098)
952301e 
Update tnt/icons based on the latest v2 and v3 fonts available + add the following new tnt icons:
"tnt/build-apps"
"tnt/build-work-zone"
"tnt/build-process-automation"
"tnt/indicator"
"tnt/indicator-active"
"tnt/task-optional"
"tnt/task-done"
"tnt/ai-1"
"tnt/ai-2"
"tnt/bound-validation-rule"
"tnt/fiori-application"
"tnt/build-code"
tsanislavgatev pushed a commit that referenced this pull request Feb 20, 2024
@ilhan007 @tsanislavgatev
feat: update tnt/icons to v3.5 (#8098)
c54d9c5 
Update tnt/icons based on the latest v2 and v3 fonts available + add the following new tnt icons:
"tnt/build-apps"
"tnt/build-work-zone"
"tnt/build-process-automation"
"tnt/indicator"
"tnt/indicator-active"
"tnt/task-optional"
"tnt/task-done"
"tnt/ai-1"
"tnt/ai-2"
"tnt/bound-validation-rule"
"tnt/fiori-application"
"tnt/build-code"
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nnaydenow nnaydenow nnaydenow approved these changes

@pskelin pskelin Awaiting requested review from pskelin

Assignees
No one assigned
Labels
feature request TOPIC Core
Projects
Planning - Topic Core
Status: Completed
Planning - Topic Core
  
Completed
Milestone
1.22.0
Development

Successfully merging this pull request may close these issues.

[Feature Request]: Update tnt/icons to v3.5
2 participants
@ilhan007 @nnaydenow