feat(ui5-checkbox): add displayOnly mode #8111
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ilhan007
reviewed
Jan 15, 2024
| } | ||
|
|
||
| get displayOnlyIcon() { | ||
| if (this.isCompletelyChecked) { |
There was a problem hiding this comment.
Thank you for the quick reaction. I think we only import the "@ui5/webcomponents-icons/dist/accept.js"; icon.
Do we need more icons imports - complete, tri-state, border.
There was a problem hiding this comment.
Yes, I forgot to add them. Thanks!
plamenivanov91
requested changes
Jan 16, 2024
| @@ -40,6 +40,7 @@ | |||
| <ui5-title>Change Event Test</ui5-title> | |||
| <ui5-checkbox id="cb1" text="Long long long text"></ui5-checkbox> | |||
| <ui5-checkbox id="cb2" disabled></ui5-checkbox> | |||
| <ui5-checkbox id="displayOnlyCb" display-only></ui5-checkbox> | |||
| <ui5-input id="field"></ui5-input> | |||
There was a problem hiding this comment.
can we add all of its variants for easier theme checking like this
<ui5-checkbox display-only checked></ui5-checkbox>
<ui5-checkbox display-only indeterminate checked></ui5-checkbox>
There was a problem hiding this comment.
That makes sense, Thanks!
Fixed, thanks for catching that. |
plamenivanov91
approved these changes
Jan 16, 2024
PetyaMarkovaBogdanova
pushed a commit
that referenced
this pull request
Jan 17, 2024
* feat(ui5-checkbox): add displayOnly mode * chore: import icons * fix: icon color in dark themes and add more examples
ilhan007
pushed a commit
that referenced
this pull request
Jan 19, 2024
* feat(ui5-checkbox): add displayOnly mode * chore: import icons * fix: icon color in dark themes and add more examples
tsanislavgatev
pushed a commit
that referenced
this pull request
Feb 20, 2024
* feat(ui5-checkbox): add displayOnly mode * chore: import icons * fix: icon color in dark themes and add more examples
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #7911