You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Since we've upgraded our app from @ui5/webcomponents@1.16.0 to 1.20.0, we've been getting some errors logged in our sentry that look like this:
We are not able to reproduce it yet, but the current assumption is that some browser quirk (like this one) or some auto-fill feature generates KeyboardEvents with undefined as key sometimes.
Thus, it would be nice to add some optional chaining for the key field here, in order to prevent logging noise.
Especially since this is a global event handler (we are not even using any Toast component in our app) that gets called a lot.
Please check the handleGlobalKeydown method of ui5-toast web component. On android mobile device, there are cases when e.key returns undefined so e.key.toLowerCase() throws an error.
Since we've upgraded our app from
![image](https://private-user-images.githubusercontent.com/1227637/297307334-64246ed6-b1f5-4060-85ff-f9256a0a72cc.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjMyNzU4NTQsIm5iZiI6MTcyMzI3NTU1NCwicGF0aCI6Ii8xMjI3NjM3LzI5NzMwNzMzNC02NDI0NmVkNi1iMWY1LTQwNjAtODVmZi1mOTI1NmEwYTcyY2MucG5nP1gtQW16LUFsZ29yaXRobT1BV1M0LUhNQUMtU0hBMjU2JlgtQW16LUNyZWRlbnRpYWw9QUtJQVZDT0RZTFNBNTNQUUs0WkElMkYyMDI0MDgxMCUyRnVzLWVhc3QtMSUyRnMzJTJGYXdzNF9yZXF1ZXN0JlgtQW16LURhdGU9MjAyNDA4MTBUMDczOTE0WiZYLUFtei1FeHBpcmVzPTMwMCZYLUFtei1TaWduYXR1cmU9OTk1NzNiOTc5ZDE1YTI3MzA0NDA5Y2Q2YjlkZTE0MzAwMjI2MWIxZDE4NjY3MzRjY2QyY2U1YWVlNDU3NjdjYyZYLUFtei1TaWduZWRIZWFkZXJzPWhvc3QmYWN0b3JfaWQ9MCZrZXlfaWQ9MCZyZXBvX2lkPTAifQ.JQGAJLz8FfR319r-L_Ds0ZXqKi2CIQR0x5ihoVWU4Po)
@ui5/webcomponents@1.16.0
to1.20.0
, we've been getting some errors logged in our sentry that look like this:We are not able to reproduce it yet, but the current assumption is that some browser quirk (like this one) or some auto-fill feature generates KeyboardEvents with
undefined
askey
sometimes.Thus, it would be nice to add some optional chaining for the
key
field here, in order to prevent logging noise.Especially since this is a global event handler (we are not even using any Toast component in our app) that gets called a lot.
ui5-webcomponents/packages/main/src/Toast.ts
Line 25 in c99d0ec
The text was updated successfully, but these errors were encountered: