fix(ui5-split-button): use correct params #8140
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
unazko
requested changes
Jan 22, 2024
There was a problem hiding this comment.
Hello @hinzzx,
The arrow button active state is as per specification now.
There is one issue left with the Emphasized button focused and active state:
In the picture the Emphasized arrow button is set to active and focused .
The expected result in this case would be to see the focus border with a blue color.
Actual - the focus border is white and it's not recognizable.
|
Hi colleagues @ilhan007 @nnaydenow, Just for clarity, we discussed offline that this is a separate issue not introduced by the change, for which we opened new incident. Best regards, |
unazko
approved these changes
Jan 22, 2024
nnaydenow
approved these changes
Jan 29, 2024
tsanislavgatev
pushed a commit
that referenced
this pull request
Feb 20, 2024
With this change we apply the correct parameters, and align the Split Button with the Visual Specifications.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After updating the theming version and adapting new values of the css parameters, we found few issues we had in the SplitButton.
With this change we apply the correct parameters, and align the Split Button with the Visual Specifications.
Fixes: #8136