fix(ui5-multi-input): fix multiple token addition #8144
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
niyap
requested changes
Jan 19, 2024
There was a problem hiding this comment.
Please check the following scenario:
Open the MultiComboBox test page. Check the sample with dynamic suggestions. I just enhanced it to add only two items with text "One" and "Two" instead of six items, the width of the ui5-multi-combobox to be the same(210px) and density to be "Compact".
Here is the result:
niyap
approved these changes
Jan 22, 2024
ilhan007
pushed a commit
that referenced
this pull request
Jan 25, 2024
* fix(ui5-multi-input): fix multiple token addition Fixes: #8049
tsanislavgatev
pushed a commit
that referenced
this pull request
Feb 20, 2024
* fix(ui5-multi-input): fix multiple token addition Fixes: #8049
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #8049