Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ShellBar]: e.preventDefault() on "menu-item-click" event does not prevent closing of overflow popover #8149

Closed
1 task done
f16r opened this issue Jan 19, 2024 · 4 comments · Fixed by #8172
Closed
1 task done
Assignees
Labels
bug This issue is a bug in the code CBC High Prio TOPIC P
Milestone

Comments

@f16r
Copy link

f16r commented Jan 19, 2024

Bug Description

[ui5-shellbar]: e.preventDefault() on "menu-item-click" event does not prevent closing of overflow popover

Affected Component

ShellBar

Expected Behaviour

I expect that the popover does not close.

Isolated Example

https://codesandbox.io/p/sandbox/ui5-webcomponents-playground-forked-d795hj?file=%2Fsrc%2Findex.js%3A5%2C29-5%2C46

Steps to Reproduce

  1. Open Menu Items dropdown
  2. Select Menu Item

Log Output, Stack Trace or Screenshots

No response

Priority

Very High

UI5 Web Components Version

1.21.2

Browser

Chrome

Operating System

Win 11

Additional Context

No response

Organization

CBC

Declaration

  • I’m not disclosing any internal or sensitive information.
@f16r f16r added the bug This issue is a bug in the code label Jan 19, 2024
@nnaydenow nnaydenow added this to Issues in Maintenance - Topic P via automation Jan 22, 2024
@nnaydenow
Copy link
Contributor

nnaydenow commented Jan 22, 2024

Hello @sap/ui5-webcomponents-topic-p,

Could you please check this issue because preventing the event doesn't take effect?

@ilhan007
Copy link
Member

Hi @f16r could you explain the urgency matter, we have seen the Very High priority requested by you.

@f16r
Copy link
Author

f16r commented Jan 22, 2024

@ilhan007 does not work as promised in the docs https://sap.github.io/ui5-webcomponents/playground/?path=/docs/fiori-shellbar--docs and has the potential to break a key functionality of an application: E. g. select a list item in single select mode to later confirm the selection by a button at the bottom of the popover.
In my case it will only delay the delivery of a US; so prio High might also be sufficient for now.

Thanks for taking care of the issue!

@f16r
Copy link
Author

f16r commented Jan 22, 2024

Here is an adjusted example https://codesandbox.io/p/sandbox/ui5-webcomponents-playground-forked-c5sjl9?file=%2Findex.html%3A21%2C8 with ui5-li component directly passed to the slot since everything in the slot is already wrapped with ui5-list component. But described behaviour is the same.

@dobrinyonkov dobrinyonkov self-assigned this Jan 23, 2024
@dobrinyonkov dobrinyonkov added this to New in Planning - Topic P via automation Jan 23, 2024
@dobrinyonkov dobrinyonkov removed this from Issues in Maintenance - Topic P Jan 23, 2024
@dobrinyonkov dobrinyonkov moved this from New to Approved in Planning - Topic P Jan 23, 2024
Planning - Topic P automation moved this from Approved to Completed Jan 25, 2024
@dobrinyonkov dobrinyonkov added this to the 1.22.0 milestone Jan 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This issue is a bug in the code CBC High Prio TOPIC P
Projects
Status: Completed
Development

Successfully merging a pull request may close this issue.

5 participants