fix(ui5-color-palette): add i18n text for default color button's text #8157
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tsanislavgatev
approved these changes
Jan 22, 2024
ilhan007
pushed a commit
that referenced
this pull request
Jan 25, 2024
…#8157) Currently in our `<ui5-color-palette>` and `<ui5-color-palette-popover>` components the *'More Colors...'* button have its text in the i18n Bundle, while in the *'Default Color'* button the text was hardcoded, which is inconsistent and leads to a non-translated text in different regions. - With this change we added the text of the *'Default Color'* button in the I18N Bundle.
tsanislavgatev
pushed a commit
that referenced
this pull request
Feb 20, 2024
…#8157) Currently in our `<ui5-color-palette>` and `<ui5-color-palette-popover>` components the *'More Colors...'* button have its text in the i18n Bundle, while in the *'Default Color'* button the text was hardcoded, which is inconsistent and leads to a non-translated text in different regions. - With this change we added the text of the *'Default Color'* button in the I18N Bundle.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently in our
<ui5-color-palette>and<ui5-color-palette-popover>components the 'More Colors...' button have its text in the i18n Bundle, while in the 'Default Color' button the text was hardcoded, which is inconsistent and leads to a non-translated text in different regions.With this change we added the text of the 'Default Color' button in the I18N Bundle.
Fixes: #8155