Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ui5-toolbar-ITEMS]: events are not dispatched correctly with a prefix #8164

Closed
1 task done
MapTo0 opened this issue Jan 23, 2024 · 1 comment · Fixed by #8169
Closed
1 task done

[ui5-toolbar-ITEMS]: events are not dispatched correctly with a prefix #8164

MapTo0 opened this issue Jan 23, 2024 · 1 comment · Fixed by #8169
Assignees
Labels
bug This issue is a bug in the code High Prio TOPIC P

Comments

@MapTo0
Copy link
Member

MapTo0 commented Jan 23, 2024

Bug Description

Hello Colleagues,

The events of all toolbar items are not dispatched correctly. Native events like Click work fine due to same mapping in the native word but custom events are not working the right way.

I see that there is already a test in the ToolbarSelect for that which is commented?
Please uncomment and fix the issue: https://github.com/SAP/ui5-webcomponents/blob/main/packages/main/test/specs/ToolbarSelect.spec.js#L35-L51

Since this is a blocker for our delivery I would consider that as a high / very high incident.
If you need more information regarding our use case feel free to contact me or Hristo Petrov.

Affected Component

all ui5 toolbar items and elements extending them

Expected Behaviour

ui5-change is fired

Isolated Example

No response

Steps to Reproduce

https://github.com/SAP/ui5-webcomponents/blob/main/packages/main/test/specs/ToolbarSelect.spec.js#L35-L51

Log Output, Stack Trace or Screenshots

No response

Priority

None

UI5 Web Components Version

latest

Browser

Chrome, Edge, Firefox, Safari

Operating System

No response

Additional Context

No response

Organization

No response

Declaration

  • I’m not disclosing any internal or sensitive information.
@MapTo0 MapTo0 added bug This issue is a bug in the code High Prio labels Jan 23, 2024
@MapTo0 MapTo0 added this to Issues in Maintenance - Topic P via automation Jan 23, 2024
@ilhan007
Copy link
Member

@SAP/ui5-webcomponents-topic-p could you have a look and let us know if you need support from our side.

@dobrinyonkov dobrinyonkov self-assigned this Jan 24, 2024
@dobrinyonkov dobrinyonkov moved this from Issues to In Progress in Maintenance - Topic P Jan 24, 2024
Maintenance - Topic P automation moved this from In Progress to Completed Jan 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This issue is a bug in the code High Prio TOPIC P
Projects
Status: Completed
Development

Successfully merging a pull request may close this issue.

3 participants