feat(ui5-shellbar): new event added #8197
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I do not see any issues. The only thing I want to verify before merge is that architects also agree with the new API field names, as those cannot be undone once added. In particular, the "isVisible" field. I also prefer shorter and concise names. Let's just double-check with them and I'd suggest to merge right after. |
kineticjs
approved these changes
Feb 1, 2024
tsanislavgatev
pushed a commit
that referenced
this pull request
Feb 20, 2024
New event search-button-click is added, which allows different actions to be triggered when it is fired on the search button inside the ui5-shellbar. If its preventDefault method is called, the default action of the search button (expanding/collapsing the input) won`t be triggered, but let the users trigger their own. Related: #6273
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New event search-button-click is added, which allows different actions to be triggered
when it is fired on the search button inside the ui5-shellbar.
If its preventDefault method is called, the default action of the search button
(expanding/collapsing the input) won`t be triggered, but let the users trigger their own.
Related: #6273