Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ui5-breadcrumbs): render current location as link #8206

Merged
merged 3 commits into from
Jan 31, 2024

Conversation

kineticjs
Copy link
Contributor

Reflects the new design requirement that the breadcrumb item for current page should also be a link that refreshes the page.

@kineticjs kineticjs marked this pull request as ready for review January 31, 2024 08:29
Copy link
Member

@yanaminkova yanaminkova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks good, only it would be good to add the functionality about refreshing the current page, when the current location link is clicked.

@kineticjs
Copy link
Contributor Author

Good point! Done

@kineticjs kineticjs merged commit 01f5542 into SAP:main Jan 31, 2024
8 checks passed
@kineticjs
Copy link
Contributor Author

thanks

tsanislavgatev pushed a commit that referenced this pull request Feb 20, 2024
* fix(ui5-breadcrumbs): render current location as link

* fix(ui5-breadcrumbs): reload page on current-page item click
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants