fix(ui5-step-input): remove value rounding, apply value-state #8293
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
unazko
reviewed
Feb 23, 2024
tsanislavgatev
requested changes
Feb 26, 2024
unazko
reviewed
Feb 29, 2024
unazko
approved these changes
Mar 1, 2024
tsanislavgatev
requested changes
Mar 12, 2024
nnaydenow
previously requested changes
Apr 11, 2024
ilhan007
reviewed
Apr 18, 2024
tsanislavgatev
approved these changes
May 9, 2024
ilhan007
pushed a commit
that referenced
this pull request
May 13, 2024
Remove value rounding, apply value-state Fixes: #8293
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our
<ui5-step-input>component used to round off the numbers based on thevaluePrecisionproperty. However this wasn't always the desired behavior.For that reason we decided to give the application developers more control over the component and removed the rounding of the value if
valuePrecisionproperty is provided. To inform users about the correctness of their input based on thevaluePrecisionproperty, we now set avalueStateon the component. This shows whether the input value meets the required precision.Note: The
valueStatechanging could be easily prevented by preventing thevalue-state-changeevent.For refference Check this PR
Closes: #8086