-
Notifications
You must be signed in to change notification settings - Fork 253
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(ui5-barcode-scanner-dialog): add 'open' property #8316
Conversation
This change introduces a new `open` property to the `ui5-barcode-scanner-dialog` component, enhancing the control over the dialog's visibility. This feature aligns with the behavior of other similar components, providing a more consistent user experience. Related: #8072
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In the .hbs file add this to the dialog
?open="{{_open}}"
Try to add some tests with the newly added code (might simply try the method and the new prop if they get too complex for real-life flow).
By the way with the code I suggested, the |
I considered your suggestion to add
|
* feat(ui5-barcode-scanner-dialog): add 'open' property This change introduces a new `open` property to the `ui5-barcode-scanner-dialog` component, enhancing the control over the dialog's visibility. This feature aligns with the behavior of other similar components, providing a more consistent user experience. Related: #8072
This change introduces a new
open
property to theui5-barcode-scanner-dialog
component, enhancing the control over the dialog's visibility. This feature aligns with the behavior of other similar components, providing a more consistent user experience.Related: #8072