fix(ui5-multi-combobox): close popover & empty value on selection #832
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ilhan007
changed the title
ilhan007
previously approved these changes
Oct 11, 2019
ilhan007
dismissed
their stale review
if you focus the checkbox and press Enter I am not sure if this is count for using checkbox
|
Fixes #768 |
ilhan007
requested changes
Oct 14, 2019
ilhan007
reviewed
Oct 14, 2019
packages/main/src/MultiComboBox.js
Outdated
| @@ -402,6 +404,12 @@ class MultiComboBox extends UI5Element { | |||
| }); | |||
|
|
|||
| this.fireEvent("selectionChange", { items: this._getSelectedItems() }); | |||
|
|
|||
| if (isEnter(event.detail) || (!event.detail.selectionComponentPressed && !isSpace(event.detail))) { | |||
There was a problem hiding this comment.
I think you can remove the isEnter(event.detail) check, when the checkbox is on focus and Enter is pressed, selectionComponentPressed would be still false
and both conditions would be true:
isEnter(event.detail) - > true
!event.detail.selectionComponentPressed && !isSpace(event.detail)) - true
Let`s assume that pressing Enter on the Item or on the checkbox is the same for simplicity
ilhan007
approved these changes
Oct 16, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.