Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ui5-progress-indicator): visual fix #8333

Merged
merged 2 commits into from
Mar 7, 2024
Merged

fix(ui5-progress-indicator): visual fix #8333

merged 2 commits into from
Mar 7, 2024

Conversation

yanaminkova
Copy link
Member

Fixes: #8306

plamenivanov91
plamenivanov91 requested changes Mar 7, 2024
View reviewed changes
Copy link
Contributor

@plamenivanov91 plamenivanov91 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we are going to delete _ui5_progress_indicator_value_state_information_border_color and the others, I would advice to delete them from the parameters.css files as well.

@yanaminkova yanaminkova merged commit 012fc4d into main Mar 7, 2024
9 checks passed
@yanaminkova yanaminkova deleted the pi-fix branch March 7, 2024 12:56
nnaydenow pushed a commit that referenced this pull request Mar 20, 2024
@yanaminkova
fix(ui5-progress-indicator): visual fix (#8333)
427eb3f 
Fixes: #8306
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@plamenivanov91 plamenivanov91 plamenivanov91 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[ui5-progress-indicator]: progress indicator looks broken
2 participants
@yanaminkova @plamenivanov91