Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ui5-bar): align subheader style #8412

Merged
merged 4 commits into from
Mar 11, 2024
Merged

fix(ui5-bar): align subheader style #8412

merged 4 commits into from
Mar 11, 2024

Conversation

tsanislavgatev
Copy link
Contributor

fixes: #8079

@unazko unazko self-requested a review March 8, 2024 13:13
hinzzx
hinzzx approved these changes Mar 11, 2024
View reviewed changes
Copy link
Contributor

@hinzzx hinzzx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

unazko
unazko requested changes Mar 11, 2024
View reviewed changes
Copy link
Contributor

@unazko unazko left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Тhere is still a line between the header and the sub-header in horizon and fiori high contrast themes.
According to the visual spec there shouldn't be such in those variants as well.

unazko
unazko requested changes Mar 11, 2024
View reviewed changes
Copy link
Contributor

@unazko unazko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is still a line between the two ui5-bar instances in high contrast themes.
It seems that the top margin in those cases should be -3px instead of -2px.
BarBoxShadow

unazko
unazko approved these changes Mar 11, 2024
View reviewed changes
Copy link
Contributor

@unazko unazko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The issue is due to the Chrome zooming feature. As a result the box shadow width isn't consistent on particular zoom levels. Same isn't reproducible with Safari and Firefox browsers.

Works fine on all browsers without zoom.

@tsanislavgatev tsanislavgatev merged commit e42a976 into main Mar 11, 2024
9 checks passed
@tsanislavgatev tsanislavgatev deleted the bar-subheader-fix branch March 11, 2024 14:22
nnaydenow pushed a commit that referenced this pull request Mar 20, 2024
@tsanislavgatev
fix(ui5-bar): align subheader style (#8412)
77286ba 
fixes: #8079
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@unazko unazko unazko approved these changes

@hinzzx hinzzx hinzzx approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[ui5-bar] SubHeader shows a line when combined with Header
3 participants
@tsanislavgatev @unazko @hinzzx