-
Notifications
You must be signed in to change notification settings - Fork 253
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(ui5-button): provide focus support for mobile #8414
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works as expected and according to the task description.
Why hasn't the |
There was a misunderstanding between the team, we will remove it :) |
I was wondering why all the focus handlers in the split button are still necessary? Ideally, there should be no focus handlers on the split button hbs, but in case something is wrong with the focus, we are working on a framework change that will allow you to use delegatesFocus
This will be a solution for #8437, so please check if it will improve the split button implementation. You can set it manually in UI5Element.ts
|
Hey Peter, We are using the focus handlers to manage which element gets focus, depending on if we get focus through mouse or keyboard. From what I understand, "delegatesFocus" will make it so that whenever the inner buttons are focused, the focus goes to the entire split button. However, we only want focus on the entire split button when navigating with a keyboard. Otherwise, the focus should remain on the inner buttons if they were focused by a mouse click. If you have any ideas for how we could achieve this without focus handlers, I appreciate your feedback! |
My point is that it is very strange to attach a focus handler on an element and then call I commented both Please check if this can be simplified, otherwise you can go ahead with the change if I don't understand all details why this is necessary. |
Hey @pskelin , you're right the As discussed seperately, the handlers will be removed at a later time. |
wdio.js file has Also the tests will pass after a rebase from main. |
Button elements can now receive focus when using keyboards on mobile devices. Focus outline is now displayed via CSS pseudo-classes and no longer relies on using the
[focused]
attribute.The following components were updated:
Fixes: #8178
Related to: #8322