fix(ui5-avatar): fix default size appearance and font-family #8415
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nnaydenow
approved these changes
Mar 11, 2024
nnaydenow
pushed a commit
that referenced
this pull request
Mar 20, 2024
- Fix missing font-family. Avatar used to not set font-family and relies on inheriting it which is not always the case. (In storybook this is not visible as the font is set on the body and the Avatar is inheriting it). - Fix default size appearance. When the "size" attribute is not present, the initials font was wrong as styles for the default "S" are applied only when the "size" attribute is present, which by default is missing:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
now good
Previously the font was a bit different - one larger than the other
Now fine
