feat(ui5-busy-indicator): added property text-placement #8471
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…cator_text_placment
added example and additional test
GerganaKremenska
requested review from
dimovpetar,
TeodorTaushanov and
BorisDafov
ilhan007
reviewed
Mar 19, 2024
added example and additional test
…omponents into busy_idicator_text_placment
updated sample
BorisDafov
suggested changes
Mar 20, 2024
texts are updated
|
I approve the PR from UA perspective |
TeodorTaushanov
approved these changes
Mar 20, 2024
ilhan007
reviewed
Mar 20, 2024
| text-align: center; | ||
| } | ||
|
|
||
| .ui5-busy-indicator-text-placement-top { |
There was a problem hiding this comment.
Some points for improvement.
Instead of creating, switching classes:
get classes() {
textPosition: {
"ui5-busy-indicator-text-placement-top ": this.textPlacement === BusyIndicatorTextPlacement.Top,
"ui5-busy-indicator-text-placement-bottom ": this.textPlacement === BusyIndicatorTextPlacement.Bottom,
},
}.ui5-busy-indicator-text-placement-top {
margin-bottom: 0.5rem
}
.ui5-busy-indicator-text-placement-bottom {
margin-top: 0.5rem;
}you can just add styles based on the attribute:
:host([text-placement="Top"]) .ui5-busy-indicator-text {
margin-bottom: 0.5rem
}
:host(:not([text-placement)) .ui5-busy-indicator-text,
:host([text-placement="Bottom"]) .ui5-busy-indicator-text {
margin-top: 0.5rem;
}We do it like this when we can - when the conditions are simple enough to cover with attribute selectors.
There was a problem hiding this comment.
#8482 taking care of improvment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BGSOFUIRODOPI-3214
FIXES: #7701