fix(ui5-upload-collection): update ui5-upload-collection Drag and Drop overlay color #8616
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updates the ui5-upload-collection drag and drop text and icon color according to the latest specification
kskondov
force-pushed
the
upload_collection_dnd_color
branch
from
1b6758b
to
e824bfc
Compare
dimovpetar
requested changes
Apr 3, 2024
There was a problem hiding this comment.
The following things are not up to date with the Horizon specs:
ui5_upload_collection_drag_overlay_bordershould use--sapField_BorderColor.uc-dnd-overlay,.uc-dnd-overlay::beforeand.uc-dnd-overlay::afterneedborder-radius: 0.5rem;.uc-dnd-overlay::beforeneeds lower opacity -0.5--ui5_upload_collection_drop_overlay_backgroundmust bevar(--sapContent_DragAndDropActiveColor);
dimovpetar
requested changes
Apr 3, 2024
…ollection_dnd_color
Updates ui5-upload-collection style parameters according to the latest design specification
kskondov
changed the title
dimovpetar
requested changes
Apr 4, 2024
packages/fiori/src/themes/sap_horizon/UploadCollection-parameters.css
Outdated
Show resolved
Hide resolved
dimovpetar
requested changes
Apr 4, 2024
packages/fiori/src/themes/sap_horizon_hcb/UploadCollection-parameters.css
Outdated
Show resolved
Hide resolved
…ollection_dnd_color
Address review comments
Updates high contrast themes border
dimovpetar
approved these changes
Apr 5, 2024
kskondov
added a commit
that referenced
this pull request
May 8, 2024
…p overlay color (#8616) * fix(ui5-upload-collection): correct drag and drop text and icon color Updates the ui5-upload-collection drag and drop text and icon color according to the latest specification * fix(ui5-upload-collection): update parameters for horizon theme Updates ui5-upload-collection style parameters according to the latest design specification * fix(ui5-upload-collection): update horizon high contrast themes Address review comments * fix(ui5-upload-collection): correct drag and drop text and icon color Updates high contrast themes border * fix(ui5-upload-collection): correct drag and drop text and icon color Review comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates the
ui5-upload-collectionDrag and Drop overlay color according to the latest spacifications