Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ui5-li): add support for F2 key #8619

Merged
merged 3 commits into from
Apr 16, 2024
Merged

Conversation

kineticjs
Copy link
Contributor

@kineticjs kineticjs commented Apr 3, 2024

Related to: #7736

-When a list-item is focused, pressing F2 now focuses the first focusable element inside the list-item
-Pressing F2 again toggles the focus back to the entire list-item

@kineticjs kineticjs marked this pull request as ready for review April 3, 2024 11:37
@kineticjs
Copy link
Contributor Author

This is a second version of PR #8597
This version avoid repeating the same code in both CustomListItem and CustomTreeItem by placing the shared code in the base ListItem instead.
The downside is that all classes that inherit from the base ListItem will be affected (e.g. their "keydown" listeners become async) , while the new code is needed only for CustomListItem and CustomTreeItem

Please check both versions (this one and the previous PR8597 ) and comment on the approach.

@kineticjs kineticjs merged commit 24c3807 into SAP:main Apr 16, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants