Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(ui5-list): enable hierarchical groups #8632

Merged
merged 70 commits into from
Apr 18, 2024
Merged

refactor(ui5-list): enable hierarchical groups #8632

merged 70 commits into from
Apr 18, 2024

Conversation

dobrinyonkov
Copy link
Contributor

@dobrinyonkov dobrinyonkov commented Apr 4, 2024 •
edited
Loading

Removes the ui5-li-groupheader component.

BREAKING CHANGE: The ui5-li-groupheader component is removed. Groups can now be created with the ui5-li-group. Instead of using ui5-li-groupheader as separator in a flat structure:

<ui5-list>
  <ui5-li-groupheader>Actions</ui5-li-groupheader>
  <ui5-li>Delete Product</ui5-li>
  <ui5-li>Audit Log Settings</ui5-li>
  <ui5-li-groupheader>Products</ui5-li-groupheader>
  <ui5-li>Product 1</ui5-li>
</ui5-list>

The API supports nesting of ui5-li components inside an ui5-li-group with the header-text property:

<ui5-list>
  <ui5-li-group header-text="Actions">
    <ui5-li>Delete Product</ui5-li>
    <ui5-li>Audit Log Settings</ui5-li>
  </ui5-li-group>
</ui5-list>

or with the header slot:

<ui5-list>
  <ui5-li-group>
    <div slot="header" style="width: '100%'; display: flex; justify-content:space-between; align-items:center;">
        <span>Back End Developers</span>
        <ui5-icon name="navigation-right-arrow"></ui5-icon>
    </div>
    <ui5-li>Delete Product</ui5-li>
    <ui5-li>Audit Log Settings</ui5-li>
  </ui5-li-group>
</ui5-list>

In addition, the the List's items slot getter, will now return ui5-li-group instances as well. There is a new readonly getter listItems will return an array flat structure containing listitems and group header items.

Relates to #8461

Nayden Naydenov and others added 30 commits March 21, 2024 11:39
Merge remote-tracking branch 'origin/main' into release-2.0
4390a18
@nnaydenow
refactor(framework): remove internet explorer related checks (#8494)
7656a93 
Internet Explorer as is no longer supported. With this change, we're removing all Internet Explorer-related checks from the framework.

BREAKING CHANGE: "Device#isIE" method has been removed and no longer available

Related to #8461
@nnaydenow
refactor(framework): remove the CSP module (#8496)
aa463d9 
Previously, we used <style> and <link> tags to style web components due to the lack of browser support for adoptedStyleSheets. However, as  latest version of all relevant browsers now support "adoptedStyleSheets", we are removing all additional functionality that was implemented to compensate for the missing support and rely entirely on "adoptedStyleSheets". As a result, there is no need of additional handling to full-fill Content Security Policy (CSP) requirements, because adoptedStyleSheets are CSP compliant.

BREAKING CHANGE: Removed the `CSP.js` module and the creation of `<style>` and `<link>` tags, as all browsers now support adoptedStyleSheets. The following APIs are not available any more and should not be used:
```ts
import { setUseLinks } from "@ui5/webcomponents-base/dist/CSP.js"
import { setPackageCSSRoot } from "@ui5/webcomponents-base/dist/CSP.js"
import { setPreloadLinks } from "@ui5/webcomponents-base/dist/CSP.js"
```

Related to [#8461](#8461)
@dimovpetar
refactor(ui5-card): remove ICardHeader interface (#8497)
601247e 
Removes the `ICardHeader` interface as no other header types are currently supported or requested.

BREAKING CHANGE: Removed the `ICardHeader` interface. If you previously used the interface
```ts
import type { ICardHeader } from "@ui5/webcomponents-base/dist/Card.js"
```
Use the CardHeader type instead:
```ts
import type CardHeader from "@ui5/webcomponents-base/dist/CardHeader.js"
```

Related to [#8461](#8461)
@dimovpetar
refactor(ui5-upload-collection): remove IUploadCollectionItem interfa…
492e338 
…ce (#8504)

Removes the `IUploadCollectionItem` interface as no other item types are currently supported or requested.

BREAKING CHANGE: Removed the `IUploadCollectionItem` interface. If you previously used the interface:
```js
import type { IUploadCollectionItem} from "@ui5/webcomponents-fiori/dist/UploadCollection.js"
```
Use the `UploadCollectionItem` type instead:
```js
import type UploadCollectionItem from "@ui5/webcomponents-fiori/dist/UploadCollectionItem.js"
```

Related to #8461
@dimovpetar
refactor(ui5-busy-indicator): rename BusyIndicatorSize values to S, M…
e44547c 
… and L (#8509)

Renames the values of BusyIndicatorSize from "Small", "Medium" and "Large" to "S", "M" and "L".

BREAKING CHANGE: The `size` property now accepts different values. If you previously used it like:
```html
<ui5-busy-indicator size="Small"></ui5-busy-indicator>
```
Now use the new values instead:
```html
<ui5-busy-indicator size="S"></ui5-busy-indicator>
```

Related to #8461
@dimovpetar
refactor(ui5-card-header): rename status to additionalText (#8507)
e5c7faf 
Renames the `status` property to `additionalText` and its shadow part.

BREAKING CHANGE: The `status` property and its shadow part have been renamed. If you previously used them:
```html
<style>
    .cardHeader::part(status) { ... }
</style>
<ui5-card-header status="3 of 10"></ui5-popover>
```
Now use `additionalText` instead:
```html
<style>
       .cardHeader::part(additional-text) { ... }
</style>
<ui5-card-header class="cardHeader" additional-text="3 of 10"></ui5-card-header>
```

Related to #8461
@dimovpetar
refactor(ui5-carousel): rename pageIndicatorStyle to pageIndicatorType (
a3aa04e 
#8511)

Renames the property `pageIndicatorStyle` to `pageIndicatorType` and enumeration `PageIndicatorStyle` to `PageIndicatorType`.

BREAKING CHANGE: The `pageIndicatorStyle` no longer exists. If you previously used it like:
```html
<ui5-carousel page-indicator-style="Numeric"></ui5-carousel>
```
Now you should use `pageIndicatorType` instead:
```html
<ui5-carousel page-indicator-type="Numeric"></ui5-carousel>
```

Related to #8461
@nnaydenow
refactor(framework): remove render method (#8501)
62d235d 
Removed the deprecated `UI5Element#render` method of the UI5Element class and replaced it with `UI5Element#renderer`.

BREAKING CHANGE:  Removed `UI5Element#render` method in favour of `UI5Element#renderer`. If you previously used "render"
```js
class MyClass extends UI5Element {
    static get render() {
        return litRenderer;
    }
}
```
start using "renderer"
```ts
class MyClass extends UI5Element {
    static get renderer() {
        return litRenderer;
    }
}
```

Related to [#8461](#8461)
@nnaydenow
refactor(tools): remove js option from generation templates (#8503)
17ae152 
With the release of version 2.0, we strongly encourage component development to be done in TypeScript. Consequently, we are discontinuing the option to generate JavaScript projects and components, as the tooling will no longer support them by default.

BREAKING CHANGE: Remove  JavaScript template option from @ui5/create-webcomponents-package
Previously `npm init @ui5/webcomponents-package` used to create JS-based project, however now it will be TypeScript-based project.
If you previously used `npm init @ui5/webcomponents-package --enable-typescript` to create  TypeScript-based project, now it's by default, e.g `npm init @ui5/webcomponents-package` and `--enable-typescript` is removed.

Related to [#8461](#8461)
@ilhan007
Merge branch 'main' into rel-2.0
96dca3c
@nnaydenow
chore: remove unused command (#8506)
0789c34
@dimovpetar
refactor(ui5-popover): rename PopoverHorizontalAlign and PopoverPlace…
d6f2836 
…mentType values (#8502)

Renames the `Left` and `Right` values of `PopoverHorizontalAlign` and `PopoverPlacementType` to `Start` and `End`.

BREAKING CHANGE: The `Left` and `Right` options option have been renamed. If you previously used them to set the placement or the alignment of the popover:
```html
<ui5-popover horizontal-align="Left" placement-type="Left"></ui5-popover>
```
Now use `Start` or `End` instead:
```html
<ui5-popover horizontal-align="Start" placement-type="Start"></ui5-popover>
```

Related to #8461
@ilhan007
Merge branch 'main' into release-2.0
1d726ea
@ilhan007
docs: deploy v2 preview
a59844f
@ilhan007
Merge branch 'main' into release-2.0
fc963c7
@nnaydenow
refactor(icons): remove soccor icon (#8524)
0b8c7d3 
The icon `soccor` was introduced with a typo. With this update, we are removing the incorrect icon by replacing it with the icon with the correct name, `soccer`.

Before:
```html
<ui5-icon name="soccor"></ui5-icon
```

After:
```html
<ui5-icon name="soccer"></ui5-icon
```

BREAKING CHANGE: Remove `soccor` icon. Use `soccer` instead.

Related to #8461
@nnaydenow
refactor(icons-business-suite): remove add-polygone icon (#8525)
7f20176 
The icon `add-polygone` was introduced with a typo. With this update, we are removing the incorrect icon by replacing it with the icon with the correct name, `add-polygon`.

Before:
```html
<ui5-icon name="business-suite/add-polygone"></ui5-icon
```

After:
```html
<ui5-icon name="business-suite/add-polygon"></ui5-icon
```

BREAKING CHANGE: Remove `add-polygone` icon. Use `add-polygon` instead.

Related to #8461
@nnaydenow
refactor(tools): remove jsdoc plugin (#8518)
194b6b3 
Previously, the custom JSDoc plugin was replaced with @custom-elements-manifest/analyzer for generating JSON descriptions of component metadata. With this replacement, the plugin has become redundant.

BREAKING CHANGE: The JSDoc plugin has been removed, and the generation of api.json has stopped. If you previously relied on the `ui5-package/dist/api.json file`, you can now use `ui5-package/dist/custom-elements.json`

Related to: #8461
@dobrinyonkov
refactor(ui5-list): enable hierarchical groups
27b6693
@ilhan007
refactor: remove all Assets-static.js modules (#8526)
d7bb8ac 
Remove all Assets-static.js modules in favour of their dynamic counterparts - the Assets.js modules.

BREAKING CHANGE: All Assets-static.js modules are removed. If you previously imported any Assets-static.js module from any package:
```ts
import "@ui5/webcomponents/dist/Assets-static.js";
import "@ui5/webcomponents-icons/dist/Assets-static.js"
```
use the dynamic equivalent of it:
```ts
import "@ui5/webcomponents/dist/Assets.js";
import "@ui5/webcomponents-icons/dist/Assets.js"
```

Related to: #8461
@tsanislavgatev
refactor(ui5-calendar): rename selected-dates-change to `selection-…
111e585 
…change` and rename few event details (#8529)

Renames the `selected-dates-change ` event name of the Calendar to `selection-change` and the names of two event details - `values` and `dates`  to `selectedValues` and `selectedDateValues` respectively.

BREAKING CHANGE: The event `selected-dates-change ` is renamed to `selection-change`. In addition the event details
`values` and `dates` are renamed to `selectedValues` and `selectedDateValues`. If you previously used the Calendar event as follows:
```ts
myCalendar.addEventListener("selected-dates-change", () => {
    const values = e.detail.values;
    const dates = e.detail.dates;
})
```
Now you have to use the new event name and details:
```ts
myCalendar.addEventListener("selection-change", () => {
   const values = event.detail.selectedValues;
   const dates = event.detail.selectedDateValues;
})
```

Related to: #8461
@ilhan007
docs: update keyboard keys abbreviations (#8528)
6b7237e 
* docs: update keyboard key abbreviation

* chore: update

* chore: update

* chore: update
@ilhan007
Merge branch 'main' into release-2.0
76946c8
@ilhan007
Update docusaurus.config.ts
7f61f6d
@pskelin @ilhan007
docs: add reset button in playground (#8531)
5bfa36d
@pskelin @ilhan007
Update index.js
48703b0
@pskelin @ilhan007
chore: update chromedriver (#8532)
34a753c
@petyabegovska @ilhan007
chore: update LocaleData.ts
c40ff8c 
UI5 version 1.103.0 is out of support. Update to latest stable version 1.120.5.
@ilhan007
feat(framework): support sr, mk, cnr locales (#8534)
e7ae45a 
The following languages mk_MK, cnr_ME and sr_Cyrl_RS locales and languages are now available and supported by the framework and displayed by the relevant components.
To do so, the PR updates the internal openui5 core dependency from 1.120.3 to 1.120.5

Fixes: #8163
@ilhan007 ilhan007 changed the base branch from release-2.0 to main April 4, 2024 21:07
@dobrinyonkov dobrinyonkov marked this pull request as draft April 5, 2024 15:09
@dobrinyonkov dobrinyonkov marked this pull request as ready for review April 15, 2024 11:15
@dobrinyonkov dobrinyonkov merged commit 193ed52 into main Apr 18, 2024
9 checks passed
@dobrinyonkov dobrinyonkov deleted the list-2.0 branch April 18, 2024 08:55
@ilhan007 ilhan007 mentioned this pull request Apr 24, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yanaminkova yanaminkova yanaminkova approved these changes

@nnaydenow nnaydenow Awaiting requested review from nnaydenow

@vladitasev vladitasev Awaiting requested review from vladitasev

@plamenivanov91 plamenivanov91 Awaiting requested review from plamenivanov91

@ilhan007 ilhan007 Awaiting requested review from ilhan007

Assignees
No one assigned
Labels
2.0 BREAKING CHANGE
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet