fix(ui5-flexible-column-layout): improved separators borders #8639
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
So now we always have borders on both sides, is that the new design - just wanted to confirm |
It seems that in the VD the borders are applied to the columns and not separators. But I don't really see a case where the separator would be without border. Also, the issue that we are fixing is exactly the case where the separator doesn't have the needed border. If we are going to add 10+ rules (which as we see are error prone) for achieving the same goal, may be we are better with the solution in question. Let me know if you know for a case where the separator shouldn't be with border. |
ilhan007
approved these changes
Apr 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #8307