Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(ui5-list, ui5-tree, ui5-upload-collection): rename mode to selectionMode #8657

Merged
merged 3 commits into from
Apr 8, 2024

Conversation

yanaminkova
Copy link
Member

Renames the mode property of ui5-list, ui5-tree and ui5-upload-collection to selectionMode.
Also renames the ListMode enum to ListSelectionMode and its values as it follows:
SingleSelect is renamed to Single
MultiSelect is renamed to Multiple
SingleSelectBegin is renamed to SingleStart
SingleSelectEnd is renamed to SingleEnd
SingleSelectAuto is renamed to SingleAuto

BREAKING CHANGE: The mode property and the ListMode enum have been renamed.
If you have previously used the mode property and the ListMode values:

<ui5-list class="list" mode="SingleSelect">
<ui5-list class="list" mode="MultiSelect">
<ui5-upload-collection mode="SingleSelectBegin">
<ui5-upload-collection mode="SingleSelectEnd">
<ui5-tree mode="SingleSelectAuto" >
<ui5-tree mode="None" >

Now use selectionMode and Single, Multiple instead:

<ui5-list class="list" selection-mode="Single">
<ui5-list class="list" selection-mode="Multiple">
<ui5-upload-collection selection-mode="SingleStart">
<ui5-upload-collection selection-mode="SingleEnd">
<ui5-tree selection-mode="SingleAuto">
<ui5-tree selection-mode="None">

Related to #8461, #7887

@yanaminkova yanaminkova changed the title refactor(ui5-list): rename mode to selectionMode refactor(ui5-list, ui5-tree, ui5-upload-collection): rename mode to selectionMode Apr 5, 2024
@yanaminkova yanaminkova closed this Apr 8, 2024
@yanaminkova yanaminkova reopened this Apr 8, 2024
@yanaminkova yanaminkova merged commit d53b3b2 into main Apr 8, 2024
9 checks passed
@yanaminkova yanaminkova deleted the list2.0 branch April 8, 2024 11:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants