Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ui5-menu): adjust active menu item text color #8699

Merged
merged 1 commit into from
Apr 10, 2024
Merged

fix(ui5-menu): adjust active menu item text color #8699

merged 1 commit into from
Apr 10, 2024

Conversation

unazko
Copy link
Contributor

@unazko unazko commented Apr 9, 2024 •
edited

Fixes: #8681

@unazko unazko marked this pull request as ready for review April 10, 2024 11:49
@unazko unazko merged commit 1a7331d into SAP:main Apr 10, 2024
9 checks passed
@ilhan007
Copy link
Member

Reminder: You have to downport the fix in release-1.24 (as a regular PR pointing to release-1.24) as well - this is our newly introduced long term maintenance branch.
Fixes that closes specific guthub issue should also go into release-1.24
The release-1.24 has working dev set up to test your fix - test pages, new playground, old playground (whatever is more convenient)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tsanislavgatev tsanislavgatev tsanislavgatev approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[ui5-menu]: Active state text color on Menu item looks wrong in Fiori 3 theme
3 participants
@unazko @ilhan007 @tsanislavgatev