Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(ui5-illustrated-message): remove titleLevel property #8700

Merged
merged 3 commits into from
Apr 24, 2024

Conversation

yanaminkova
Copy link
Member

Removes the titleLevel property of the ui5-illustrated-message, since users can set the required title level on the title slot.
Also, now the the slotted element has proper styles and responsiveness.

BREAKING CHANGE: The titleLevel property of the ui5-illustrated-messageis removed.
If you have previously used the titleLevel property:

<ui5-illustrated-message title-level="H6>

it will no longer work for the component.

Instead, you could set the title of the ui5-illustrated-message on the title slot, as it follows

<ui5-illustrated-message>
      <ui5-title slot="title" level="H3">This is a slotted title</ui5-title>
</ui5-illustrated-message>

Related to #8461, #7887

@yanaminkova yanaminkova merged commit 9fe199c into main Apr 24, 2024
9 checks passed
@yanaminkova yanaminkova deleted the ui5-illmsg-remove-titlelevel branch April 24, 2024 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants