fix(Popup): prevent a rare runtime error #8707
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In 1.x it was possible to have this code:
without appending the dialog to the DOM tree, and it would work without throwing any errors (would just show the block layer) because the static area item was forced to be rendered even without the dialog itself being rendered.
In 2.x the same code throws a runtime error, because the blocking layer is not available before the component has been rendered (the shadow root is empty).
This fixes the error, although it is not a real use case.