Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: order slots in state as in Light DOM #874

Merged
merged 4 commits into from
Oct 22, 2019
Merged

fix: order slots in state as in Light DOM #874

merged 4 commits into from
Oct 22, 2019

Conversation

ilhan007
Copy link
Member

FIXES: #873

Order slotted children in components state properly, keeping their order in the Light DOM, not the order the children are defined.

@ilhan007 ilhan007 changed the title fix: slotted children are orderd as in Light DOM fix: slotted children are ordered as in Light DOM Oct 21, 2019
@ilhan007 ilhan007 changed the title fix: slotted children are ordered as in Light DOM fix: keep Light DOM order in component state for slotted children Oct 21, 2019
@ilhan007 ilhan007 changed the title fix: keep Light DOM order in component state for slotted children fix: order slotted children in the state as in Light DOM Oct 21, 2019
@ilhan007 ilhan007 changed the title fix: order slotted children in the state as in Light DOM fix: order slots in state as in Light DOM Oct 21, 2019
@ilhan007 ilhan007 merged commit b8efea0 into master Oct 22, 2019
@ilhan007 ilhan007 deleted the fix-slotted-children-order branch October 22, 2019 10:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vladitasev vladitasev vladitasev approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

slotted items are not ordered in component state as passed in Light DOM
2 participants
@ilhan007 @vladitasev