feat(ui5-barcode-scanner-dialog): add support for close and open events #8753
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
After the API Reviews part of the 2.0 prep, we decided to have before-open and open, before-close and close events, e.g: In the case if this PR:
|
kgogov
changed the title
Thanks for the update. I'll use 'open' instead of 'after-open' and 'close' instead of 'after-close'. |
This change adds support for `close` and `open` events to the barcode scanner dialog. Along with this change, the documentation and the sample have been updated. Fixes #8695
kgogov
force-pushed
the
barcode-scanner-dialog-enhancement
branch
from
4507f85
to
80a99f0
Compare
vladitasev
approved these changes
Apr 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds support for
closeandopenevents to the barcode scanner dialog. Along with this change, the documentation and the sample have been updated.Fixes #8695