Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(ui5-textarea): rename property growingMaxLines to growingMaxRows #8756

Merged
merged 1 commit into from
Apr 16, 2024

Conversation

niyap
Copy link
Contributor

@niyap niyap commented Apr 15, 2024

Renames the growingMaxLines property of ui5-textarea.
If you have previously used the growingMaxLines property

<ui5-textarea growing growing-max-lines="5"></ui5-textarea>

Now use growingMaxRows instead:

<ui5-textarea growing growing-max-rows="5"></ui5-textarea>

BREAKING CHANGE: The growingMaxLines property have been renamed to growingMaxRows.

Related to: #8461

@ilhan007
Copy link
Member

ilhan007 commented Apr 15, 2024

Just as reminder: when you squash the PR (the green button Squash and Merge) check the commit title, description once again, because this is what is merged - e.g proper PR description is great but not enough

@niyap niyap merged commit 3fd33ab into main Apr 16, 2024
9 checks passed
@niyap niyap deleted the textareaupdates branch April 16, 2024 11:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants